(cdocs) Update Cdocs#35755
Merged
hestonhoffman merged 11 commits intomasterfrom Apr 20, 2026
Merged
Conversation
Contributor
Preview links (active after the
|
hestonhoffman
commented
Apr 17, 2026
| ### Caveats / follow-ups | ||
|
|
||
| - **Not-found path uncovered.** English throws at compile; the `return term` branch in `glossaryTooltip.js` is only reachable for non-English pages. If coverage matters, either relax the English throw in the cdocs tag or add a parallel non-English test page — neither is in scope here. | ||
| - **Casing on SNMP looks wrong.** `toTitleCase` turns `Simple Network Management Protocol (SNMP)` into `Simple Network Management Protocol (snmp)` — it loses the caps on `SNMP` entirely. The spec asserts the actual output, but this is worth flagging to whoever owns the tag — it may be a latent bug. No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Note: I noticed this in testing and decided not to fix it. Realistically, I doubt it will come up much. Most of the time with abbreviations like this, sentence case will already be baked in to the glossary term title. It's also the way this already works in prod, so no major loss there.
jhgilbert
reviewed
Apr 20, 2026
…6133) * Revert change that broke e2e tests * Bump Cdocs version * Add e2e tests for the author console * Take the mask off the snapshots * Add snapshot * Bump Cdocs to the latest * Add e2e tests and snippet for the ui tag * Update test index
jhgilbert
approved these changes
Apr 20, 2026
hestonhoffman
removed
WORK IN PROGRESS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Releases CDOCS 3.1 with support for glossary tooltips, ui tags, and Author Console improvements.
In addition to relevant playwright tests, this PR cleans up some existing glossary files that would have caused issues.
Note: You'll notice some of these glossary files have pretty weird names. I'm going to go through and rename the ones with weird symbols/spaces etc. I think this is just a bug waiting to happen.
Merge instructions
Merge readiness: